lkml.org 
[lkml]   [2000]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] vmfixes-2.4.0-test9-B2

    On Sun, 24 Sep 2000, Linus Torvalds wrote:

    >
    >
    > On Sun, 24 Sep 2000, Andrea Arcangeli wrote:
    > >
    > > On Sun, Sep 24, 2000 at 10:26:11PM +0200, Ingo Molnar wrote:
    > > > where will it deadlock?
    > >
    > > ext2_new_block (or whatever that runs getblk with the superlock lock
    > > acquired)->getblk->GFP->shrink_dcache_memory->prune_dcache->
    > > prune_one_dentry->dput->dentry_iput->iput->inode->i_sb->s_op->
    > > put_inode->ext2_discard_prealloc->ext2_free_blocks->lock_super->D
    >
    > Whee..
    >
    > Good that you remembered (now that you mention it, I recollect that we had
    > this bug and discussion earlier).
    >
    > I added a comment to the effect, although I still moved the __GFP_IO test
    > into the icache and dcache shrink functions, because as with the
    > shm_swap() thing this is probably something we do want to fix eventually.

    Btw, why we need kmem_cache_shrink() inside shrink_{i,d}cache_memory ?
    Since refill_inactive and do_try_to_free_pages (the only functions which
    calls shrink_{i,d}cache_memory) already shrink the SLAB cache (with
    kmem_cache_reap), I dont think its needed.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:38    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean