lkml.org 
[lkml]   [2000]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: test9-pre6


On Fri, 22 Sep 2000, Linus Torvalds wrote:

> This should fix the VM deadlocks (knock wood), and adds the infrastructure
> for better samba serving. And lots of small details...

... including broken directory change events stuff. Example:
@@ -101,5 +125,10 @@
inode_setattr(inode, attr);
}
unlock_kernel();
+ if (!error) {
+ unsigned long dn_mask = setattr_mask(ia_valid);
+ if (dn_mask)
+ inode_dir_notify(dentry->d_parent->d_inode, dn_mask);
+ }
return error;
}

... and guess what happens if the object we are hitting with
notify_change() is passed to d_move() at that moment. Besides, why the
hell does fchown() do _anything_ to directory where a link to the opened
file happens to be located? To help filemanagers? Too bad, they can't rely
on it. Why? Because there may be other links.

IOW, could the authors tell what kind of semantics they wanted and
what kind of use is intended for that stuff?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.049 / U:2.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site