Messages in this thread |  | | Date | Wed, 20 Sep 2000 23:04:50 -0400 | From | Jeff Garzik <> | Subject | dev->hard_start_xmit return val handling correct? |
| |
When dev->hard_start_xmit returns an error, it doesn't seem like returning ENETDOWN is the best course of action.. Is this correct?
int dev_queue_xmit(struct sk_buff *skb) [...] if (dev->hard_start_xmit(skb, dev) == 0) { dev->xmit_lock_owner = -1; spin_unlock_bh(&dev->xmit_lock); return 0; } } dev->xmit_lock_owner = -1; spin_unlock_bh(&dev->xmit_lock); if (net_ratelimit()) printk(KERN_DEBUG "Virtual device %s asks to queue packet!\n", dev->name); kfree_skb(skb); return -ENETDOWN; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |