Messages in this thread |  | | Date | Sat, 2 Sep 2000 11:45:06 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: [patchlet] Removing unneeded line in vmtruncate() (2.4.0-t8p1) |
| |
On Sat, 2 Sep 2000, Rasmus Andersen wrote:
> > ... except that comment is there for purpose. Expanding ->truncate() > > should not set ->i_size until it's done with the metadata. You don't want > > mappings on the part currently being expanded. It doesn't matter for ext2 > > and friends, but it's a problem for FAT and friends. > > > > This is probably just me being a bit dense, but I am having problems > understanding your comment. The code path affected by my patch (and > where the comment is placed) is not part of the do_expand code path > (the "Expanding ->truncate()" from your comment?). And in do_expand > we already set i_size=offset before calling truncate(). Which you > seem to object to?
Which is a bug that cannot be fixed until ->truncate() gets new size as an explicit argument. And I doubt that having two similar methods with different ways to pass parameter (->i_size vs. argument) would be a good idea.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |