[lkml]   [2000]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patchlet] Removing unneeded line in vmtruncate() (2.4.0-t8p1)

On Fri, 1 Sep 2000, Tigran Aivazian wrote:

> Rasmus, you introduced a bug because you removed the code but left the
> comment around. now /* this should go into ->truncate */ is there and very
> confusing - what should go into ->truncate?

... except that comment is there for purpose. Expanding ->truncate()
should not set ->i_size until it's done with the metadata. You don't want
mappings on the part currently being expanded. It doesn't matter for ext2
and friends, but it's a problem for FAT and friends.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:38    [W:2.327 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site