Messages in this thread |  | | From | (Linus Torvalds) | Subject | Re: [PATCH] Useless inode semaphore locking in 2.4.0-test8 | Date | 19 Sep 2000 12:02:36 -0700 |
| |
In article <200009151200.OAA00850@mailhost.ri.silicomp.fr>, Eric PAIRE <eric.paire@ri.silicomp.fr> wrote: > >In open.c:do_truncate(), the call to notify_change() is protected by >the inode->i_sem, which seems to me useless, and thus can be removed.
And exactly how do you now protect against the race of another process doing a write() at the same time, and in particular the updates of "inode->i_size"?
As far as I can tell, you removing the semaphore means that _nothing_ protects inode->i_size any more, and you can get basically random values. That would be bad.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |