lkml.org 
[lkml]   [2000]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Re: SCSI scanning
Date

----- Original Message -----
From: "Linus Torvalds" <torvalds@transmeta.com>
To: "Torben Mathiasen" <tmm@image.dk>
Cc: <jan@gondor.com>; <linux-kernel@vger.kernel.org>;
<linux-scsi@vger.kernel.org>; <eric@andante.org>
Sent: Sunday, September 17, 2000 9:32 PM
Subject: Re: [PATCH] Re: SCSI scanning

>
>
> On Sun, 17 Sep 2000, Linus Torvalds wrote:
> >
> > This is the patch I was looking for. Thanks,
>
> Oh, grepping some more for scsi initializations, the "scsi_dev_init()"
> thing stands out.
>
> That's another case where the SCSI layer is module dependent. If it's a
> module, we use the "init_module()" in scsi/scsi.c, and if not, we instead
> use "scsi_dev_init()". They do some of the same things (well, they
> obviously would have to, otherwise there wouldn't be any point to having a
> init routine at all), but in general do it in very different ways for no
> good reason I can see.
>
> Torben, would you mind terribly expanding on your previous patch a bit,
> and also cleaning this part up? As far as I can tell, we should just
> remove scsi_dev_init() completely, and use the module init code with an
> initcall(). Two less regions of #ifdef MODULE, and one less different
> code-path to worry about..
>
> Why was this done this way anyway? I've never seen this kind of setup in
> any of the other drivers that have been de-liced of module dependencies..

Historical. SCSI was made modular very early on when the modules
technology was pretty primative. As time has gone on, the two
initialization paths have converged, and now they are essentially redundant.

The one thing that is different in the module/non-module case is for the
case of SCSI compiled into the kernel, you need to look at the list of
compiled-in host adapters. Unless of course you are cleaning that up as
well. I haven't seen the threads that got this work started, and it is only
in reading this morning's messages that I see the rationale for all these
changes in the first place. There are a couple of ways of addressing this,
some better than others, and some are more work than others. I can give you
assistance and ideas if you want.

-Eric


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:45    [from the cache]
©2003-2011 Jasper Spaans