lkml.org 
[lkml]   [2000]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][minor] Re: [patch] VIA IDE driver v2.3
On Thu, 14 Sep 2000, Vojtech Pavlik wrote:

> Thanks; applied. By the way, what would you think about getting rid of
> amd7409.c and integrating it's functionality to the VIA driver? The
> difference between the VIA and AMD chipset is in two bits in one
> register ....

I have the same idea some time ago, but it is a bad idea. AMD7409 doesn't
have many registers which VIA has (need to have separate amd_get_info() and
initialisation checks), older revisions have broken SWDMA modes (need to
diognose this and don't use SWDMA on them) and slightly diffirent setting
of UDMA (yeah two bits). Also as Andre said there are new AMD chipsets in
the way. Keeping amd7409.c is good. Instead of incorporatig it into
via82cxxx.c I have rewritten it (some time ago) to have all functionality
of your new VIA driver. But there was no feedback (I don't have access to
AMD7409) so it's not included in main tree etc... (also it needs updating
to match VIA 2.3).

Regards.
--
Bartlomiej Zolnierkiewicz
<bkz@linux-ide.org>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.069 / U:1.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site