lkml.org 
[lkml]   [2000]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: elevator code
Andi Kleen wrote:
>
> On Wed, Sep 13, 2000 at 04:29:18PM +0200, Andrea Arcangeli wrote:
> > About B) I can' believe you seriously want to duplicate the merging code
> > in each lowlevel driver given most of them could share the same code (as
> > they're doing in linux).
>
> I guess it would just be a library call. e.g. the BSDs just have a disksort()
> function that is called from the drivers as needed. For smart devices
> with very intelligent firmware you simply do not call it (assuming you
> have decently sized kiovec requests, with the current bh approach some
> premerging is probably always needed)

Yes - this is the cleanest solution in terms of code organization.
You don't need to put it into a special struct and allways track it
through
pointer derefference - it's not a true callback in nature after all,
since
it doesn't need to be called asynchronously.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.098 / U:0.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site