lkml.org 
[lkml]   [2000]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Large File support and blocks.
On Fri, Sep 01, 2000 at 03:15:27PM +0200, Andi Kleen wrote:
> The previous analysis was not quite right though (%cl is actually loaded,
> just %eax gets bogus input from the long long shift)

Perhaps, but it's sure not obvious:

bh->b_blocknr = (long)mp->pbm_bn +
(mp->pbm_offset >> inode->i_sb->s_blocksize_bits);
bh->b_blocknr >>= block_bits;

movl %eax,20(%esp) ; store shifted pbm_offset to temporary
movl %edx,24(%esp) ; "
movl 20(%esp),%eax ; load low part
addl (%esi),%eax ; b_blocknr = pbm_bn + pbm_offset
movl %ebp,%ecx ; load block_bits
shrl %cl,%eax ; b_blocknr >> block_bits

I've not got 2.95 handy, and your test case isn't executable,
so its difficult to see exactly what might be wrong here.



r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.127 / U:6.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site