lkml.org 
[lkml]   [2000]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.4.0-test6-pre8 - dark vga textmode console problem in RIVA TNT 2


On Tue, 8 Aug 2000, Dan Aloni wrote:
>
> Fixes the problem of getting a dark text mode console after switching
> from X, under systems which have the RIVA TNT 2 chipset (could be other
> systems as well, didn't check). More details about the problem was
> posted by me in lkml a few days ago.

>
> This patch was tested and it works. The problem could have been sorted
> out in another way, but I'm not much of a skilled kernel hacker to find
> out how, although I guess it is somewhere in the code that handles the
> RIVA TNT 2 chipset.

This seems to be a bug in the XF86 4.0.x code-base. The patch is wrong:
the new Linux kernel palette setting order is correct (we should set the
palette _after_ switching to the new console).

So yes, the patch will fix the problem. But I don't think it's correct.

Linus

>
> Dan Aloni (dax)
> karrde@callisto.yi.org
>
> --- linux/drivers/char/console.c Tue Aug 8 19:29:09 2000
> +++ linux/drivers/char/console.c Tue Aug 8 18:33:50 2000
> @@ -587,10 +587,10 @@
>
> if (redraw) {
> set_origin(currcons);
> + set_palette(currcons);
>
> if (sw->con_switch(vc_cons[currcons].d) && vcmode != KD_GRAPHICS) {
> /* Update the screen contents */
> - set_palette(currcons);
> do_update_region(currcons, origin, screenbuf_size/2);
> }
> }
>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.050 / U:0.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site