Messages in this thread | | | Subject | Re: [PATCH] fix SMP kernel on SMP MoBo with APIC-less CPU | Date | Wed, 9 Aug 2000 00:52:23 +0100 (BST) | From | Alan Cox <> |
| |
> > - if (smp_found_config) > > + if (smp_found_config && /* try only if the cpu has a local apic */ > > + (boot_cpu_data.x86_capability & X86_FEATURE_APIC)) > > get_smp_config(); > > This is bogus -- there are valid SMP configurations with external 82489DX > local APICs. Tell the vendor to fix your BIOS not to provide a bogus MP > table or boot with "nosmp" option instead.
The code I guess needs to spot that there isnt an APIC. The test proposed is very wrong though. A CPU can have a local apic on a SMP board with no APIC or IO-APIC set up (eg on daughtercard stuff)
There is only one sane test I can see. Figure if the CPU can have an APIC and test it. If it cant have an APIC run a 489 test if there is an MP table and actually poke the bits and see if its there
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |