lkml.org 
[lkml]   [2000]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtrr: s/suser/capable/
On Wed, 30 Aug 2000, Arnaldo Carvalho de Melo wrote:

> Please consider applying.

And then please don't apply.

> case MTRRIOC_ADD_ENTRY:
> - if ( !suser () ) return -EPERM;
> + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;

Please think further about these random changes. CAP_SYS_ADMIN
is already bloated with useless junk and these aren't helping
the situation.

These cases in mtrr.c are clearly CAP_SYS_RAWIO.

Matthew.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.120 / U:3.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site