Messages in this thread |  | | Date | Thu, 31 Aug 2000 11:27:17 +0100 (BST) | From | Matthew Kirkwood <> | Subject | Re: [PATCH] mtrr: s/suser/capable/ |
| |
On Wed, 30 Aug 2000, Arnaldo Carvalho de Melo wrote:
> Please consider applying.
And then please don't apply.
> case MTRRIOC_ADD_ENTRY: > - if ( !suser () ) return -EPERM; > + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;
Please think further about these random changes. CAP_SYS_ADMIN is already bloated with useless junk and these aren't helping the situation.
These cases in mtrr.c are clearly CAP_SYS_RAWIO.
Matthew.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |