lkml.org 
[lkml]   [2000]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix disk statistic reporting to include all disks

On 30-Aug-2000 Jens Axboe wrote:
> Right now the code in my tree looks something like this:
>
> for (i = 0; i < MAX_BLKDEV; i++) {
> request_queue_t *q = blk_get_queue(MKDEV(i, 0));
> if (!q)
> continue;
> if (!active)
> continue;
>
> /* print stats */
> }
>
> So it's not really that bad. I suppose things could be made quicker
> by just browsing a list of active queues, but I'm not sure it's worth
> the trouble (but hey, proove me wrong). Note that linking blk_dev
> does not make much sense, since not all queues are available from
> there. Drivers are free to use their own queue, even several if they
> want.

Agreed, this looks far better than the 16 x 16 table looping
that was going on before (and not getting all disks). My last question,
when you print stats will the format still be (%u,%u):(%u,%u,%u,%u)?
And now that disk_index() is going away, will the real minor number be
printed?


Bill Wilson <bill@gkrellm.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.072 / U:2.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site