lkml.org 
[lkml]   [2000]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.0-test8-pre1 on SPARC: Warning patch (take 2)
   Date: Wed, 30 Aug 2000 13:49:52 -0400
From: Horst von Brand <vonbrand@inf.utfsm.cl>

The patch to sbus_unmap_single() is done on the theory that the
least generic types mentioned for the arguments are probably right,
please check. No new warnings now (at least here).

I still don't like this change. If this is such an important issue,
why did you keep sbus_map_single returning u32, and taking long
instead of size_t as one of it's arguments?

To me, this makes it seem like an arbitrary change with no real
purpose, it's creating more problems, and leaving around a few
instances of the problem it claims to solve.

(Hint: Fix this up so it uses the correct types for all the
sbus DMA interfaces on sparc32 and I'll have no problems
with the patch. Sparc64 already does this all correctly.)

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.023 / U:5.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site