lkml.org 
[lkml]   [2000]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix disk statistic reporting to include all disks
On Tue, Aug 29, 2000 at 06:08:14PM -0700, Linus Torvalds wrote:
>
>
> On Wed, 30 Aug 2000, Jens Axboe wrote:
> >
> > Maybe I wasn't very clear... What I mean is that drivers that use
> > blk_queue_make_request (such as md) are handed buffers directly and
> > don't get requests added to their queues in the regular sense, instead
> > they remap b_rdev before ll_rw_blk gets the queue for the device and
> > adds them to the destination queue.
>
> Ho humm.. I actually kind of expected the statistics to be done in
> generic_make_request(), so that we'd have
>
> .....
> do {
> q = blk_get_queue(bh->b_rdev);
> if (!q) {
> ... no such device ..
> }
> + statistics(q, rw, bh->b_size);
> } while (q->make_request_fn(q, rw, bh)));
> ...
>
> and just remove the drive_stat_acct() thing completely.
>
> That way, we'd have a per-queue "this many reads, this many writes".

Does this setup also allow to maintain time statistics, like the times between
make_request_time, io_start_time and io_end_time so things like queuetime
and io servicetime can be determined?

-Marcel
--
======-------- Marcel J.E. Mol MESA Consulting B.V.
=======--------- ph. +31-(0)6-54724868 P.O. Box 112
=======--------- marcel@mesa.nl 2630 AC Nootdorp
__==== www.mesa.nl ---____U_n_i_x______I_n_t_e_r_n_e_t____ The Netherlands ____
They couldn't think of a number, so they gave me a name!
-- Rupert Hine

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.073 / U:1.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site