Messages in this thread |  | | Date | Wed, 30 Aug 2000 20:02:06 +0100 | From | Philipp Rumpf <> | Subject | Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups |
| |
On Wed, Aug 30, 2000 at 10:04:12AM -0700, Linus Torvalds wrote: > return copy_to_user(dst, src, size) ? -EFAULT : 0; > > is fine and quite readable. Fits on a simple line.
I agree so far. But when it's really
if (put_user(..>) return -EFAULT; if (put_user(...)) return -EFAULT; if (copy_to_user(...)) return -EFAULT; if (copy_to_user(...)) return -EFAULT;
return 0;
changing the last two statements to use ? : is just confusing (acme's changes were somewhat less extreme), don't you agree ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |