lkml.org 
[lkml]   [2000]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [patch] scheduler bugfix, SMP, 2.4.0-test7

On 29-Aug-2000 Ingo Molnar wrote:

> i agree fully. The attached patch against test8-pre1 changes
> schedule_idle() from inline to FASTCALL - things look much nicer with this
> one applied.
>
> -static inline void reschedule_idle(struct task_struct * p, unsigned long
flags)
> +static FASTCALL(void reschedule_idle(struct task_struct *, unsigned long));

You can't do this. SPARC requires you to restore the flags in the same
function where you saved them because they contain register window status.
You *have* to inline the part that drops the run queue lock. The bulk of the
function though doesn't need to be inlined. See how it is done in my
scheduler patch.

--
Dimitris Michailidis dimitris@engr.sgi.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.073 / U:5.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site