lkml.org 
[lkml]   [2000]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix disk statistic reporting to include all disks
On Tue, Aug 29 2000, Linus Torvalds wrote:
> > This patch fixes the enhanced disk statistics to report all drives
> > so IDE1 - IDE3 (/dev/hdc - /dev/hdh) can be monitored.
>
> Why not just do this right, and move the statistics into the "queue
> structure". Get rid of that ugly kstat thing. Get rid of all the special
> case lookups. We already need to have the queue structure to do the
> queuing (surprise, surprise), so suddenly statistics are (a) cheap and (b)
> right.
>
> So then /proc just needs to be changed to look at the queues instead of
> looking at this kstat thing.

Sounds sane, but what about drivers that don't really use the request
queue structure? Stuff like lvm, md, rd (with Neil's patch to fix the
lru_list deadlock), and probably new loop.

Come to think of it, regular disk stat accounting doesn't work there atm
anyway...

--
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.098 / U:2.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site