Messages in this thread |  | | Date | Sat, 26 Aug 2000 16:38:10 +0100 | From | Philipp Rumpf <> | Subject | Re: [PATCH] serial167.c: bugfixes and cleanups |
| |
On Fri, Aug 25, 2000 at 11:04:05PM +0100, Tigran Aivazian wrote: > Hi Arnaldo, > > On Fri, 25 Aug 2000, Arnaldo Carvalho de Melo wrote: > > - copy_to_user(retinfo,&tmp,sizeof(*retinfo)); > > + if (copy_to_user(retinfo,&tmp,sizeof(*retinfo))) > > + return -EFAULT; > > return 0; > > I think Linus already suggested that you do this: > > return copy_to_user(...) ? -EFAULT : 0; > > it is compact and intuitive.
I'm not too sure about that. If you want to do more things than a single copy,
if (copy_to_user(...)) return -EFAULT;
...;
return 0;
is obviously required. Also for those who don't trust strace (or don't have it, or can't use it because -EFAULT is ambiguous)
if (copy_to_user(...)) return -EFAULT;
printk("no fault\n");
return 0;
might make sense. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |