lkml.org 
[lkml]   [2000]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: IOAPIC dependency on SMP in reboot code
On Thu, 24 Aug 2000, Cesar Eduardo Barros wrote:

> In arch/i386/kernel/process.c:
>
> #if CONFIG_SMP
> /*
> * Stop all CPUs and turn off local APICs and the IO-APIC, so
> * other OSs see a clean IRQ state.
> */
> smp_send_stop();
> disable_IO_APIC();
> #endif
>
> Shouldn't the disable_IO_APIC be outside CONFIG_SMP since it can be enabled by
> another config option too?

Sure! Thanks for pointing this out. Ingo, how about this patch?

Maciej

--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +

--- process.c.macro Tue Jul 11 04:26:04 2000
+++ process.c Thu Aug 24 09:53:18 2000
@@ -340,12 +340,14 @@

void machine_restart(char * __unused)
{
-#if CONFIG_SMP
/*
* Stop all CPUs and turn off local APICs and the IO-APIC, so
* other OSs see a clean IRQ state.
*/
+#if CONFIG_SMP
smp_send_stop();
+#endif
+#if CONFIG_X86_IO_APIC
disable_IO_APIC();
#endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.029 / U:4.808 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site