lkml.org 
[lkml]   [2000]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH - final (I hope) tidy up for generic_make_request interface


On Thu, 24 Aug 2000, Neil Brown wrote:
>
> Well, yes, but my understanding from the comment:
> /*
> * Temporary solution - in 2.5 this will be done by the lowlevel
> * driver. Create a bounce buffer if the buffer data points into
> * high memory - keep the original buffer otherwise.
> */
> was that we were happy with this restriction, and that it would be
> removed in 2.5.

Note that we'll have to have some good way of handling old drivers that
don't do this.

And the best way I can come up with is to have it be done in the request
list for such drivers.

Which implies that we should not have it in the generic path, but in the
per-queue path.

> But, if you really like, I will move create_bounce back into
> elevator_request, and also into md_make_request (and probably into
> rd_make_request when I submit that patch - rd doesn't need the
> elevator algorithm at all) and resubmit.

Why is it in md_make_request() at all?

md_make_request() should be able to avoid the bounce buffers naturally:
the low-level driver may use bounce-buffers, but md shouldn't need to know
that or care. Same goes for rd_make_request() - which needs to use kmap(),
but not actually do any bounce buffers. Or did I overlook something?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.045 / U:3.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site