lkml.org 
[lkml]   [2000]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: Move of input drivers, some word needed from you
(I have read Eric's folloup to Linus' mail I'm replying to, but not
following that one up in AOL style. I second Eric mentioning the "curse
of the gifted" from own experience. You start something without design,
it succeeds for your talent, experience, whatever, it evolves and grows
and eventually disembogues into a rewrite from scratch, that time with a
design before the implementation.)

On Tue, 22 Aug 2000, Linus Torvalds wrote:

> On Wed, 23 Aug 2000, Rogier Wolff wrote:
> >
> > However, (for example:) the fact that every serial driver in Linux has
> > to do its own hangup and carrier detect logic stinks.
>
> Oh, I agree.
>
> But this is a code interface issue, in my opinion. I suspect the
> interfaces in the serial case are just not very good, and a bad interface
> will force people to duplicate code (possibly with small changes) just
> because it's a bad interface.

So, what does it boil down to? The need for an additional, well-defined
interface, encapsulating and hiding common functions. Effectively, once
the good interface is there, you will have an improved percentage of
shared code. That's what Eric is after, you wrap it up nicely into a
gift paper called interface.

Please: both of you, step back and hold a single second. You're not of
different opinions, basically.

> Getting to a good interface is non-trivial, but in the end it's the most
> important thing anybody can do. Once you have good interfaces, you can
> then get to the point where sharing is easy without having the potential
> downsides.

That's what encapsulation and sharing that encapsulated code only via
its interface are all about.

--
Matthias Andree
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.071 / U:3.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site