lkml.org 
[lkml]   [2000]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/appletalk/ddp.c: small fix in skb usage
   Date: 	Sun, 20 Aug 2000 03:18:22 -0300
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>

Please take a look and consider applying.

I can't see how this change is correct, the existing code is buggy for
sure, but the fix is nearly worse than the cure, so shouldn't the
change be:

1) sed 's/kfree(skb)/kfree_skb(skb)//'
2) If newskb == NULL, return 0
3) Else skb = newskb, and continue on to transmit the ddp message

If you agree, please send a new patch which in fact does this.

Patch not applied.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:37    [W:0.069 / U:4.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site