lkml.org 
[lkml]   [2000]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Complaint about recent LINUX_VERSION_CODEs
Jeff Garzik wrote:
>
> Brian Gerst wrote:
> >
> > Jeff Garzik wrote:
> > > My own pet peeve is ppl avoiding the KERNEL_VERSION() macro when doing
> > > LINUX_VERSION_CODE tests. Makes each test a bit more readable.
> > >
> > > Jeff
> >
> > The only logical reason to not use KERNEL_VERSION is if you want to
> > support 2.0.x (which should be deprecated, IMHO anyways).
>
> Most compat code I've seen defines KERNEL_VERSION if its absent, so
> IMNSHO one should always use K_V, even on 2.0.x :)
>
> > There are
> > also several different clones of KERNEL_VERSION sprinkled throughout the
> > kernel as well.
>
> There was a patch once which exorcised these... was it from you?

Yes, and it met with alot of static over such a cosmetic change,
consistency being irrelevant and all.

--

Brian Gerst

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [from the cache]
©2003-2011 Jasper Spaans