Messages in this thread | | | Date | Wed, 5 Jul 2000 22:08:29 -0600 | From | Richard Gooch <> | Subject | Re: [patch] Makes cpuid and msr drivers devfs aware |
| |
Philip Langdale writes: > Hi all, > > This is my first ( attempted ) contribution, so try > not to laugh too hard. :-) > > I'm not sure what the 'done thing' is when it comes to implementing > devfs support. Some drivers use #ifdef and others rely on the stub > functions in the devfs_fs_kernel.h header. I went with the first > method as there doesn't seem to be much point iterating through > the cpus to do nothing.
It's much better to not have a pile of ugly #ifdef's. I strongly recommend ripping them out. That's why I have the stub functions in the first place.
For those drivers which do have #ifdef's, it's usually because the same driver codebase is maintained for 2.2.x and 2.3.x kernels, and 2.2.x doesn't have the header file. I've asked Alan to include the header so that drivers don't need these ugly #ifdef's, but he doesn't seem to care.
Regards,
Richard.... Permanent: rgooch@atnf.csiro.au Current: rgooch@ras.ucalgary.ca
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |