Messages in this thread | | | Date | Tue, 4 Jul 2000 17:53:45 +0100 (BST) | From | Tigran Aivazian <> | Subject | Re: fs/ioctl change in test3-pre1 |
| |
the sequence
file = fget(fd);
fput(file);
in itself is SMP-safe. So, if what happens in between requires the kernel lock - so be it, but no need to move fget/fput into it. And the lock_kernel was _after_ fget() so it makes sense for unlock_kernel() to be _before_ fput().
Agree?
Tigran
On Tue, 4 Jul 2000, Tim Waugh wrote:
> This looks wrong to me. Could someone explain it? > > Thanks, > Tim. > */ > > diff -u linux/fs/ioctl.c:1.1.1.6 linux/fs/ioctl.c:1.1.1.7 > --- linux/fs/ioctl.c:1.1.1.6 Thu Jun 29 10:27:38 2000 > +++ linux/fs/ioctl.c Thu Jun 29 11:00:55 2000 > @@ -107,8 +107,8 @@ > else if (filp->f_op && filp->f_op->ioctl) > error = > filp->f_op->ioctl(filp->f_dentry->d_inod > e, filp, cmd, arg); > } > - fput(filp); > unlock_kernel(); > + fput(filp); > > out: > return error; >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |