lkml.org 
[lkml]   [2000]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH #2] console lock grabbed too early in printk...
Date
On Sun, 2 Jul 2000 00:25:16 -0700 (PDT), 
Chris Lattner <sabre@skylab.org> wrote:
>Like I said a few times already... kmalloc is only called in a situation
>where deadlock would occur before... I would have no problem calling it
>with GFP_ATOMIC and dropping the message if OOM...

I think you are missing the point. printk can be called even before
kmalloc is usable and you cannot tell if kmalloc can be called yet.
Yes, it is unlikely but crashing during debugging just complicates
things. Far better to just count and report dropped messages and never
call any other kernel functions from printk. It also keeps a critical
kernel function nice and simple.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.458 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site