Messages in this thread Patch in this message | | | Date | Thu, 27 Jul 2000 19:11:06 +0100 | From | "Stephen C. Tweedie" <> | Subject | [PATCH, 2.4pre5test6] Re: BUG in fs/ext2/super.c |
| |
Hi,
On Fri, Jul 21, 2000 at 12:36:38PM +0200, Andreas Gruenbacher wrote: > > Problem: parse_options() is called with a pointer to uninitialized > new_mount_opt in line 660. This may result is arbitrary mount options > after a remount of an ext2 filesystem.
Agreed. Patch [attached] builds, boots and still appears to do remounts correctly. :)
Cheers, Stephen --- fs/ext2/super.c.~1~ Thu Jul 27 12:20:25 2000 +++ fs/ext2/super.c Thu Jul 27 18:51:47 2000 @@ -653,6 +653,7 @@ /* * Allow the "check" option to be passed as a remount option. */ + new_mount_opt = sb->u.ext2_sb.s_mount_opt; if (!parse_options (data, &tmp, &resuid, &resgid, &new_mount_opt)) return -EINVAL; | |