Messages in this thread | | | Date | Mon, 24 Jul 2000 06:53:40 -0400 (EDT) | From | Alexander Viro <> | Subject | [Apologies] Re: [Announce] BKL shifting into drivers and filesystems - beware |
| |
On Fri, 21 Jul 2000, I wrote:
> interesting. In-tree code _had_ _been_ _updated_. If you can show a > single time when I had submitted "oh, let's break everything and let > maintainers fix it" kind of patch - you are welcome, name the version when > it had happened and accept my deep apologies.
Darn. I just realized that I did, in fact, do that. Mea maxima culpa - when I took BKL from the do_mmap() I've totally missed the fact that not all instances of ->mmap() were SMP-safe. Worse yet, during the BKL-shifting in ->release() I found ones that were not, fixed them and _still_ did not realize that the rest may have problems. The only semblance of excuse being that it was an oversight (read: sudden idiocy attack), rather than decision to break it now and fix afterwards ;-< Oh, well... Self-LART commenced, list of instances that still need fixing made (fortunately it turned to be very short - only 1 left, drm_mmap() in drivers/char/drm/vm.c), patch goes to Linus. Oh, and you have my apologies. Al
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |