lkml.org 
[lkml]   [2000]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kiobugs in 2.3.48
> > map = get_page_map(map, ptr);
> > and now we pass this to get_page_map() which promptly returns 0,
>
> Yikes. Yes, somebody snuck a completely bogus patch into 2.3.48. The
> _only_ reason vaddr should be used in get_page_map() is to act as an
> argument to ZERO_PAGE() for architectures in which the zero page is
> cache-coloured.

my patch, my fault, sorry. I mistakenly assumed vaddr to be a kernel address.
however, the previous code was
if (MAP_NR(page) >= max_mapnr)
return 0;
which is also bogus. if the intention is to detect if it's outside "struct
page *" memory, then
if (page - mem_map >= max_mapnr)
return 0;
makes more sense.

ganesh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [W:0.030 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site