[lkml]   [2000]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: 2.3.48 compile problems: (ac97_codec.c)
Frank de Lange wrote:
> On Sun, Feb 27, 2000 at 12:03:12PM -0500, Jeff Garzik wrote:
> > So, unless it is required by the module, IMNSHO you should not include
> > sound_config.h...
> Here's a patch for ac97_config.c which does NOT includes the private
> sound_config.h header, instead it includes <linux/soundcard.h> <linux/fs.h> and
> <asm/uaccess.h>

Looks good to me, applied to my local tree.

small style point: traditionally all headers in include/linux are
ordered above headers in include/asm-xxx, unless there is a specific
reason to do otherwise.


Jeff Garzik | "Are you the police?"
Building 1024 |
MandrakeSoft, Inc. | "No ma'am. We're musicians."
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:56    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean