Messages in this thread | | | Date | Sun, 27 Feb 2000 12:35:26 -0500 | From | Jeff Garzik <> | Subject | Re: 2.3.48 compile problems: (ac97_codec.c) |
| |
Frank de Lange wrote: > > On Sun, Feb 27, 2000 at 12:03:12PM -0500, Jeff Garzik wrote: > > So, unless it is required by the module, IMNSHO you should not include > > sound_config.h... > > Here's a patch for ac97_config.c which does NOT includes the private > sound_config.h header, instead it includes <linux/soundcard.h> <linux/fs.h> and > <asm/uaccess.h>
Looks good to me, applied to my local tree.
small style point: traditionally all headers in include/linux are ordered above headers in include/asm-xxx, unless there is a specific reason to do otherwise.
Jeff
-- Jeff Garzik | "Are you the police?" Building 1024 | MandrakeSoft, Inc. | "No ma'am. We're musicians."
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |