lkml.org 
[lkml]   [2000]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: cardbus problem (with oops)

Hi,

I had the same problems that ejecting a cardbus card locked up my notebook.
I traced it down to pci_remove_device(), which does

if (dev->driver->remove)
{
...
}

The check itself causes the oops because for my cardbus device (3c575)
dev->driver is NULL. The only driver which works okay is the tulip_cb
which does a pci_register_device instead of register_device (all other
cardbus cards call this).

The quick fix would be
if (dev->driver && dev->driver->remove)
{
...
}

which makes it more robust against misuse. But I guess the prefered way
is to fix the cardbus drivers to register the devices as pci devices correctly.

Danilo
--
Danilo Beuche Phone: +49-391-67-11459
Universität Magdeburg Fax: +49-391-67-12810
Computer Science Department Raum D207a
EMail: danilo@ivs.cs.uni-magdeburg.de
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:56    [W:0.217 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site