lkml.org 
[lkml]   [2000]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Serial cardbus code.... for testing, please.....
Linus Torvalds wrote:
> On Sat, 9 Dec 2000, Theodore Y. Ts'o wrote:
> > I didn't have time to do more than just quickly apply the patch and leave
> > in a hurry, but my Vaio certainly recognized the serial port on the combo
> > cardbus card I have with this patch. Everything looked fine - I got a
> > message saying it found a 16450 on ttyS4 when I plugged the card in.
> >
> > When you have a chance, can you check and make sure that you actually
> > can talk to the modem? That will make me feel much better.....
>
> Done.
>
> It works perfectly fine for me, with the following caveat:
>
> It crashes hard if I remove the card while the modem is in use, though (ie
> insert card, point minicom at it, sit at the minicom window while removing
> the card).
>
> This is a problem that many drivers have: when the card is removed, the
> driver sees an interrupt (which happens to be the CardBus card removal
> interrupt, but the serial driver doesn't know that, and the way cardbus
> interrupts work it's always shared with the driver).
>
> So the serial driver reads the modem status byte, which is all ones, and
> decides that there is a ton of work to do. It then loops forever, because
> the status byte bits will obviously continue to be all ones.
>
> Note how the "rs_interrupt()" routine _tries_ to avoid this by having a
> pass counter value, but that logic never triggers because we will loop
> forever in receive_chars(), so the rs_interrupt() counter never even gets
> to increment.

Other places in serial.c check for 0xff, which implies we can and should
do the same in the interrupt handler...

> /*
> * If we read 0xff from the LSR, there is no UART here.
> */
> if (serial_in(info, UART_LSR) == 0xff)
> return -1;

I'm starting to think this Ositech Jack of Spades is unusual in some
way, since your (Linus) BestData card and other serial CardBus cards
sound like they work.

Jeff


--
Jeff Garzik |
Building 1024 | These are not the J's you're lookin' for.
MandrakeSoft | It's an old Jedi mind trick.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.075 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site