Messages in this thread |  | | Date | Fri, 8 Dec 2000 10:26:30 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH,preliminary] cleanup shm handling |
| |
On 8 Dec 2000, Christoph Rohland wrote: > > here is my first shot for cleaning up the shm handling. It did survive > some basic testing but is not ready for inclusion.
The only comment I have right now is that you probably should not mark the page dirty in "nopage" - theoretically somebody might have a sparse mapping and depend on zero pages for the ones that aren't touched. It's better to delay the dirty marking until swapout() (and write(), when that is implemented), so that we don't needlessly create swap entries for zero pages.
(No, probably nobody does this for traditional shared memory, but I could well imagine mmap() on /dev/zero with most of the pages being read-only).
Other than that the approach at least looks reasonable. And cleaner than what we currently have.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |