Messages in this thread |  | | From | Peter Samuelson <> | Date | Wed, 6 Dec 2000 10:40:49 -0600 (CST) | Subject | Re: kernel panic in SoftwareRAID autodetection |
| |
[Brian Kress <kressb@fsc-usa.com>] > I got resounding silence to posting the patch last time, so I'm not > sure if anyone actually wants this patch,
Well, I like it, but admittedly it's mostly in the "cleanup" category (though it does fix the LVM name issue) so at this point in 2.4 I guess Linus has more important stuff to worry about.
The best thing about your patch is that by putting the logic back in the individual drivers, it makes check.c not depend on your module configuration (so you can compile a disk module, either inside or outside the kernel tree, without worrying about editing or recompiling check.c).
> +char *DAC960_disk_name(struct gendisk *hd, int minor, char *buf) > +char *cciss_disk_name(struct gendisk *hd, int minor, char *buf) > +char *ida_disk_name(struct gendisk *hd, int minor, char *buf) > +char* ide_disk_name(struct gendisk *hd, int minor, char *buf) > +char *lvm_hd_name(struct gendisk *, int, char *); > +char *lvm_hd_name(struct gendisk *hd, int minor, char *buf) > +char *md_disk_name(struct gendisk*, int, char *); > +char * md_disk_name(struct gendisk *hd, int minor, char* buf) > +char *scsi_disk_name(struct gendisk *hd, int minor, char *buf)
These should all be 'static char *'.
Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |