Messages in this thread Patch in this message |  | | Date | Wed, 6 Dec 2000 03:06:36 -0500 (EST) | From | Alexander Viro <> | Subject | [PATCH] Re: test12-pre6 |
| |
truncate() and ftruncate() return values are different from the POSIX requirements and from the values returned by other Unices (and from our own manpages, BTW). Trivial fix follows. Rationale: see truncate(2), ftruncate(2), POSIX or try to call the thing on other Unices.
Please, apply.
diff -urN rc12-pre5/fs/open.c rc12-pre5-truncate/fs/open.c --- rc12-pre5/fs/open.c Wed Nov 29 21:37:31 2000 +++ rc12-pre5-truncate/fs/open.c Tue Dec 5 14:53:59 2000 @@ -102,7 +102,12 @@ goto out; inode = nd.dentry->d_inode; - error = -EACCES; + /* For directories it's -EISDIR, for other non-regulars - -EINVAL */ + error = -EISDIR; + if (S_ISDIR(inode->i_mode)) + goto dput_and_out; + + error = -EINVAL; if (!S_ISREG(inode->i_mode)) goto dput_and_out; @@ -163,7 +168,7 @@ goto out; dentry = file->f_dentry; inode = dentry->d_inode; - error = -EACCES; + error = -EINVAL; if (!S_ISREG(inode->i_mode) || !(file->f_mode & FMODE_WRITE)) goto out_putf; error = -EPERM; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |