Messages in this thread |  | | Date | Wed, 6 Dec 2000 08:56:27 +0000 (GMT) | From | Tigran Aivazian <> | Subject | Re: [PATCH] Re: test12-pre6 |
| |
On Wed, 6 Dec 2000, Tigran Aivazian wrote: > error = -EPERM; > if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) > goto dput_and_out;
also, while we are here -- are you sure that EPERM is a good idea for IS_IMMUTABLE(inode)? Other parts of Linux return EACCES in this case. Maybe it would be more consistent to do EACCES here too? This would simply mean remove IS_IMMUTABLE() from the above if because vfs_permission() does return -EACCES if we ask MAY_WRITE for IS_IMMUTABLE inode.
Since, the SuSv2 standard is silent on the issue of immutable files (they are Linux-specific) then it may make sense to be consistent?
Regards, Tigran
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |