lkml.org 
[lkml]   [2000]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i810_audio 2.4.0-test11
Hi!

> > It implements mono output and fixes a bug in the dma logic (reset necessary
> > because some descriptors are already prefetched and are not updated
>
> This is wrong. Linus please do not apply this patch, or if you have done back
> it out. Not only does it do format conversions in kernel (which is a strict
> not to be done in the sound driver policy) it also makes it impossible to make
> mmap work correctly with the OSS API definitions.
>
> Tjeerd. I deliberately applied only small bits of your patch before because
> the mono mode stuff clutters the driver horribly and is not in the right place.
> It belongs in the application/libraries

Then you should kill parts of drivers/usb/audio - it contains format conversions.
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:51    [W:0.078 / U:5.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site