Messages in this thread Patch in this message |  | | Date | Fri, 29 Dec 2000 18:09:49 +0100 | From | Andrea Arcangeli <> | Subject | wake-one-3 bug (affected 2.2.19pre3aa[123]) |
| |
On Sun, Dec 24, 2000 at 04:40:09PM +0100, Andrea Arcangeli wrote: > On Sun, Dec 24, 2000 at 11:23:33AM +1100, Andrew Morton wrote: > > ack. > > This patch against 2.2.19pre3 should fix all races. (note that wait->flags > doesn't need to be initialized in the critical section in test1X too) > > ftp://ftp.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.19pre3/wake-one-3 > > Comments?
Woops, it had a bug (I overlooked the usage of __add_wait_queue in sleep_on), the bug was reproduced and fixed by Chris Mason and his fix is obviously right, see:
--- 2.2.19pre3aa3/kernel/sched.c.~1~ Wed Dec 27 04:49:37 2000 +++ 2.2.19pre3aa3/kernel/sched.c Fri Dec 29 17:03:09 2000 @@ -1018,6 +1018,7 @@ #define SLEEP_ON_HEAD \ wait.task = current; \ + wait.flags = 0; \ write_lock_irqsave(&waitqueue_lock,flags); \ __add_wait_queue(p, &wait); \ write_unlock(&waitqueue_lock); New patch (revision n.4) against vanilla 2.2.19pre3 is here:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.19pre3/wake-one-4
Since 2.2.19pre3aa[123] included the wake-one-3 patch they can generate task in D state blocked in sleep_on* too. So if you're running 2.2.19pre3aa[123] you should either upgrade to 2.2.19pre3aa4 or to apply the above inlined one liner on top of 2.2.19pre3aa[123] sources and recompile (just make bzImage again will be enough).
Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |