[lkml]   [2000]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

    On Thu, 28 Dec 2000, Chris Mason wrote:
    > Linus and Rik are cc'd in to find out if this is a good idea in
    > general.


    There are some arguments for starting the writeout early, but there are
    tons of arguments against it too (the main one being "avoid doing IO if
    you can do so"), so your patch is probably fine. In the end, the
    performance characteristics are what matters. Does the patch make for
    smoother behaviour and better performance?

    Anyway, the "can_get_io_locks" check is subsumed by the "launder_loop"
    check: we will never set "launder_loop" to non-zero if we can't get the
    io_locks, so you might as well just make the test be

    /* First loop through? Don't start IO, just move it to the back of the list */
    if (!launder_loop) {

    and be done with it.

    I'd like to hear what that does for dbench.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 12:52    [W:0.019 / U:5.400 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site