Messages in this thread Patch in this message |  | | From | "H. Peter Anvin" <> | Subject | Re: [patch-2.4.0-test12-pre3] microcode update for P4 (fwd) | Date | 1 Dec 2000 21:29:46 -0800 |
| |
Followup to: <Pine.LNX.4.21.0012011150490.877-100000@penguin.homenet> By author: Tigran Aivazian <tigran@veritas.com> In newsgroup: linux.dev.kernel > > Second attempt -- the first one got lost due to some local mail client > problems... > > Hi Linus, > > Here is the patch to microcode update driver to support the new P4 > CPU. > > --- linux/include/asm-i386/msr.h Thu Oct 7 18:17:09 1999 > +++ ucode/include/asm-i386/msr.h Fri Dec 1 09:38:59 2000 > @@ -30,3 +30,7 @@ > : "=a" (low), "=d" (high) \ > : "c" (counter)) > > +/* symbolic names for some interesting MSRs */ > +#define IA32_PLATFORM_ID 0x17 > +#define IA32_UCODE_WRITE 0x79 > +#define IA32_UCODE_REV 0x8B >
Please call these MSR_* instead, "IA32_*" isn't very descriptive, besides, the preferred prefix in existing locations in the Linux kernel is "X86_", e.g. X86_EFLAGS_IF or X86_CR4_PSE. I think there are standard symbolic names for most MSRs in volume 3 of the Intel processor manuals; I would suggest we use those.
-hpa -- <hpa@transmeta.com> at work, <hpa@zytor.com> in private! "Unix gives you enough rope to shoot yourself in the foot." http://www.zytor.com/~hpa/puzzle.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |