lkml.org 
[lkml]   [2000]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Adaptec AIC7XXX v 6.0.6 BETA Released
On Wed, 13 Dec 2000, Justin T. Gibbs wrote:

> >Thanks for posting this. Unfortunately, the kernel won't build unless you
> >restore this macro to the namespace after aic7xxx_linux.h blows it away:
> >
> >--- linux-2.2.18/drivers/scsi/hosts.c.orig Wed Dec 13 20:27:34 2000
> >+++ linux-2.2.18/drivers/scsi/hosts.c Wed Dec 13 20:26:22 2000
> >@@ -137,6 +137,7 @@
> >
> > #ifdef CONFIG_SCSI_AIC7XXX
> > #include "aic7xxx/aic7xxx_linux.h"
> >+#define current get_current()
> > #endif
> >
> > #ifdef CONFIG_SCSI_IPS
> >
> >
> >Steve
>
> I take it you had other controllers enabled? I tested this against
> 2.2.18-pre24 and didn't see any problems. I didn't enable anything
> other than the aic7xxx driver.

Yes, I have an IBM ServeRaid controller in addition to the on-board
7890. Any includes which lexically follow your new aic7xxx driver in
hosts.c will be similarly affected.

> Luckily, in newer kernels, the per-controller includes are no longer
> required in hosts.c. None-the-less, it seems to me that spamming
> the kernel namespace with "current" in at least the way that the
> 2.2 kernels do (does this occur in later kernels?) should be corrected.
> As you can see from my comment in aic7xxx_linux.h, I was very surprised
> to see this occur.
>
> I'll update my patch tomorrow to restore the definition of current.
> I do fear, however, that this will perpetuate the polution of the
> namespace should "current" ever get cleaned up.

I won't wade into this controversy (sick of dimpled chads, I guess).

Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.152 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site