Messages in this thread Patches in this message | | | Date | Sun, 10 Dec 2000 20:29:44 -0600 | Subject | Re: test12-pre8 | From | Peter Samuelson <> |
| |
[Linus] > - pre8:
Small thinko in arch/mips64/Makefile, looks like.
--- 2.4.0test12pre8/arch/mips64/Makefile~ Sun Dec 10 20:07:02 2000 +++ 2.4.0test12pre8/arch/mips64/Makefile Sun Dec 10 20:13:07 2000 @@ -33,7 +33,7 @@ # machines may also. Since BFD is incredibly buggy with respect to # crossformat linking we rely on the elf2ecoff tool for format conversion. # -CFLAGS += -I $(TOPDIR)/include/asm $(CFLAGS) +CFLAGS := -I $(TOPDIR)/include/asm $(CFLAGS) CFLAGS += -mabi=64 -G 0 -mno-abicalls -fno-pic -Wa,--trap -pipe LINKFLAGS += -G 0 -static # -N MODFLAGS += -mlong-calls
But that brings up the question: why does mips64 need to specify the '-I $(TOPDIR)/include/asm-mips64' at all? A quick grep through arch/mips64 and include/asm-mips64 does not reveal any reason.
So AFAICS it should actually be
--- 2.4.0test12pre8/arch/mips64/Makefile~ Sun Dec 10 20:07:02 2000 +++ 2.4.0test12pre8/arch/mips64/Makefile Sun Dec 10 20:13:07 2000 @@ -33,7 +33,6 @@ # machines may also. Since BFD is incredibly buggy with respect to # crossformat linking we rely on the elf2ecoff tool for format conversion. # -CFLAGS += -I $(TOPDIR)/include/asm $(CFLAGS) CFLAGS += -mabi=64 -G 0 -mno-abicalls -fno-pic -Wa,--trap -pipe LINKFLAGS += -G 0 -static # -N MODFLAGS += -mlong-calls
Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |