Messages in this thread |  | | Date | Thu, 9 Nov 2000 16:06:52 +0300 | From | Andrey Panin <> | Subject | Re: [PATCH] media/radio [check_region() removal... ] |
| |
On Wed, Nov 08, 2000 at 07:13:46PM -0500, Jeff Garzik wrote:
Hi all,
> > Finally, a word to you, Alan, and others doing request_region work: it > is more informative to pass the device name (minor, etc.) into > request_region. Ditto for request_irq. Many (most, except net?) > drivers use board/chip name instead of registered interface name. If > you can use the interface name for request_region or request_irq, use > it... it allows differentiation between multiple boards of the same > type. That's especially when looking at ISA regions in /proc/ioports, > or interrupt counts in /proc/interrupts. >
two question about this:
1) how about drivers requesting 2 (or more) irq for one device ? AFAIK some PowerMac net drivers do it (bmac.c for example).
2) i found that some net drivers (3c527.c, sk_mca.c) use io region and don't call request_region() at all. Should they be fixed ?
Best regards, Andrey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |