Messages in this thread |  | | Date | Wed, 08 Nov 2000 23:02:06 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] media/radio [check_region() removal... ] |
| |
Bartlomiej Zolnierkiewicz wrote: > > On Wed, 8 Nov 2000, Jeff Garzik wrote: > > > Patch looks generally ok. Some of the whitespace/formatting changes are > > questionable, I usually leave that up to the maintainer unless it is > > very gratuitously opposite to CodingStyle. > > > > These drivers seem to be unmantained :) > Anyway if this is a problem I can undo these changes ...
I don't have any problem with them. Make sure you CC the individual maintainers of the drivers... some of the pop up every now and then :)
> > Some of the driver messages ("foo version 1.0") are purposefully printed > > -after-, not before, the device is probed and registered. Your patch > > gets this wrong in at least one place. > > > > Yes... I wasn't sure about this... can undo...
When in doubt, follow the behavior of the existing driver. :) Especially since we're in a freeze, and stuff...
-- Jeff Garzik | Building 1024 | Would you like a Twinkie? MandrakeSoft | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |