Messages in this thread |  | | Date | Fri, 3 Nov 2000 20:51:55 -0800 | From | "David S. Miller" <> | Subject | Re: 2.2.x BUG & PATCH: recvmsg() does not check msg_controllen correctly |
| |
From: Philippe Troin <phil@fifi.org> Date: 03 Nov 2000 19:53:04 -0800
Yes I agree, mixing signed and unsigned arithmetic is evil... Doesn't gcc have a flag for unsafe signed/unsigned mixtures ?
Would you consider this patch (or a variant) for inclusion ?
I would accept a patch which made the code set fdmax <= 0 when (msg->msg_controllen < (sizeof(struct cmsghdr) + sizeof(int))) because it is the sole reason this bug exists at all.
Later, David S. Miller davem@redhat.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |