lkml.org 
[lkml]   [2000]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: 2.4.0-test11 ext2 fs corruption


On Thu, 30 Nov 2000, Daniel Phillips wrote:

> Alexander Viro wrote:
> > Bloody hell...
>
> I don't know if this is the bug he's got, in fact I doubt it, but it's a
> bug and it needs fixing. The problem is, ext2_get_group_desc
> effectively returns two results; one of them is being assigned from on
> conditional paths and the other isn't. This bug will cause - on very
> rare occasions - the wrong group descriptor block to be marked dirty,
> and changes might be lost. I think what we'd see as a result is wrong
> block, inode and directory counts.
>
> The fix below is kind of gross. The way I really want to do the fix is
> to remove one parameter from ext2_get_group_desc and thereby get rid of
> the troublesome side effect for good, but that kind of change isn't
> compatible with 'code freeze'.

Yes, it is. Moreover, correct solution is slightly different and changes
ext2_get_group_desc() semantics. Wait until tomorrow, OK?

However, it's not the source of reported problems. We clearly have b0rken
data in bitmaps themselves.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:49    [W:0.058 / U:5.736 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site