lkml.org 
[lkml]   [2000]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: plug problem in linux-2.4.0-test11
    On Wed, Nov 29 2000, schwidefsky@de.ibm.com wrote:
    > request queue to put them on its internal queue. You could argue
    > that it shouldn't dequeue request if q->plugged == 1. On the other
    > hand why not, before the disk has nothing to do. Anyway the result

    I agree with your reasoning, even if the s390 behaviour is a bit
    "non-standard" wrt block devices. Linus, could you apply?

    --- drivers/block/ll_rw_blk.c~ Wed Nov 29 15:17:33 2000
    +++ drivers/block/ll_rw_blk.c Wed Nov 29 15:18:43 2000
    @@ -347,10 +347,9 @@
    */
    static inline void __generic_unplug_device(request_queue_t *q)
    {
    - if (!list_empty(&q->queue_head)) {
    - q->plugged = 0;
    + q->plugged = 0;
    + if (!list_empty(&q->queue_head))
    q->request_fn(q);
    - }
    }

    static void generic_unplug_device(void *data)
    --
    * Jens Axboe <axboe@suse.de>
    * SuSE Labs
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:47    [W:0.020 / U:2.756 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site