lkml.org 
[lkml]   [2000]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: bug in count_open_files() or a strange granularity?
On Tue, 28 Nov 2000, Richard B. Johnson wrote:
> Yes. This is probably related to the previously-reported MOD_INC_USE_COUNT
> macro in the drivers. The open count is now handled in the call to
> the driver's open(). The MOD_INC_USE_COUNT and the MOD_DEC_USE_COUNT
> should now be defined to do nothing for kernels that already handle
> the counts in the calls.

Hi Richard,

Although your comment had nothing to do with my question -- I still
would like to point out that:

a) the driver in question (/dev/cpu/micocode) deals with module accounting
correctly by using THIS_MODULE in the fops, it doesn't use
MOD_INC/DEC_USE_COUNT macros

b) No, those macros should NOT be defined to do nothing because the Linux
kernel is a lot more than just set of drivers. There are subsystems that
still need them.

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:47    [W:0.078 / U:2.536 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site